Add an editor

[gabriel-tessier]

leandrodamascena commented 20 days ago

And about editor it´s a simple editor from https://ace.c9.io/..

[gabriel-tessier]

@mingrammer
@leandrodamascena
What about this version?

Still need to put back some style on button etc... and fix code.
only thing working is clicking on example generate the img files.

[leandrodamascena]

Hmm, I liked this version! Maybe adding information about that tool at the top?

[mingrammer]

Looks good as an initial version! We can improve it with more modern styles (maybe a lot of JS/CSS works needed)

I can also work for it and send you a PR soon.

[gabriel-tessier]

Thank you for the review.

I'll continue fixing errors.

@leandrodamascena Do you know about how the editor can handle the error I found nothing in the doc?
Now I return the python stacktrace and display in place of the diagrams picture.... If there's some battery included in the editor it can be great.

@mingrammer I put the default theme maybe there's certainly one with better render, depends on what you plan to do, here the list:
https://github.com/ajaxorg/ace/tree/master/lib/ace/theme

And I saw that the editor can handle redo and undo actions...

https://ace.c9.io/demo/toolbar.html

I'll try this one.

There's a lot to do!

[leandrodamascena]

I'm not sure about the error handler in this editor.. But we might use try blocks in flask to check this information and returns a human readable error..

I'll check one thing in diagrams code, thinking about get error from there

[mingrammer]

I think we should show the thrown stack traces as it is with pop-up like interface on the editor panel. I used toastr library for such this purpose before.

[leandrodamascena]

Great idea @mingrammer. I already used toastr and it's really good to show messages.

[leandrodamascena]

Hi guys. Leaving feedback, I had some difficult days here. But now I am back and I can work on it.

[gabriel-tessier]

@mingrammer @leandrodamascena

I created a team and took the diagams-web before somebody else take it :)

I sent you invitations with team we will have discussion tools it will make more easy to manage as I'm lost with all the issues...

You also become owner so it will make also more easy to manage.