Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fail to verify RPC notifications #21

Open
battlmonstr opened this issue Aug 2, 2017 · 0 comments
Open

fail to verify RPC notifications #21

battlmonstr opened this issue Aug 2, 2017 · 0 comments

Comments

@battlmonstr
Copy link

When a notification message is read (type = 2), MPVerifyMessage is called on that message, and fails, because the logic for checking the notification should be different.

The notification has only 3 elements:
https://github.com/gabriel/MPMessagePack/blob/master/RPC/MPRPCProtocol.m#L83

And it has no message ID:
https://github.com/gabriel/MPMessagePack/blob/master/RPC/MPRPCProtocol.m#L98

P.S. There's MPVerifyRequest and MPVerifyResponse, it would be nice to have MPVerifyNotification as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant