Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make trading fees configurable for each pool #561

Open
jakubgregus opened this issue Sep 21, 2022 · 1 comment
Open

Make trading fees configurable for each pool #561

jakubgregus opened this issue Sep 21, 2022 · 1 comment
Assignees
@mrq1911

Comments

@jakubgregus
Copy link

Basilisk-node/pallets/xyk/src/lib.rs

Line 94 in 9624ace

type GetExchangeFee: Get<(u32, u32)>;

@mrq1911
Copy link
Member

mrq1911 commented Sep 22, 2022 •
edited
Loading

i think we can make this change with minimal impact on the API and existing code by introducing new storage with a fee per pool (current constant will be the default) and extrinsic set_fee callable by the specified origin.

The question is who (the origin) will be able to set the fee? referendum?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mrq1911 mrq1911

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mrq1911 @jakubgregus