-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Take the background color from the input image #39
Comments
Many scanned images have lots of noise at the edges so a one pixel test could produce the inverse of expectation, what may be better is a user defined sample zone (say N x N e.g. N<=8 pixels for averaging) and a variable location such as X,Y that could be from 0,0 up to image max X-N,Y-N. |
Good remark, just maybe the passing of all this over the command line might be a bit clunky.
|
Last one looks ok to me if documented well enough
|
I would keep "-b" so there's more free letters for new features :) |
Look fine, Looking forward to a release and closure just a Small Matter Of Programming :big grin: |
I've been doing some experiments with "local" background fill color ("extending the sides of the page") where the fill is not of uniform color everywhere and looks better in case like (often seen) one side of the scanned page is lighter/darker than the other one. |
@galfar no sure if your "not of uniform" is reference to if the scan is "faded/bleached" one side or the background is "graduated/gradient" you start getting into double threshold values where colour range becomes more difficult such that gui rgb histograms become a more complex step/need However a "range" can be collected by using a long margin strip either "side to side" or "top to bottom" or a user defined second sample box. |
Your "margin strip" describes it better. Some heavy blur or other method is needed on the repeated strip however to hide the tiling artifacts. |
Request came in to extend "-b" background color parameter to take it's value from the input image (edge/corner).
https://galfar.vevb.net/wp/projects/deskew/comment-page-2/#comment-184847
The text was updated successfully, but these errors were encountered: