Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic IMU Example #416

Open
Krabbenhoft opened this issue Dec 6, 2023 · 6 comments
Open

Basic IMU Example #416

Krabbenhoft opened this issue Dec 6, 2023 · 6 comments
Labels
Software Has to do with software Type: New Page

Comments

@Krabbenhoft
Copy link

What information should be added?
I started working on a draft of possible IMU information. I am hoping to get feedback on if this is headed in the right direction and what major changes need to be made (I still need to review the style guide and maybe expand some things).

https://docs.google.com/document/d/1Pbkl8GGNRPcUUfDdw1RvUQzDddL5vIVZ5e9TMxxhzw8/edit

Does it need it's own page? (Yes/No): Yes

If it needs a page, which section should it be in? If it doesn't, which page should it be under?
It should go under the programming tutorials section.

@abidingabi abidingabi added Type: New Page Software Has to do with software labels Dec 6, 2023
@abidingabi
Copy link
Member

Overall, it looks pretty good, but a couple preliminary notes:

  • The turning code should probably be using a P controller
  • It should also deal with turning in the shortest direction and what happens when you hit the point where the angles range

@Krabbenhoft
Copy link
Author

I am not a very advanced programmer, is it okay to reference using a PID controller and include code that scales the speed according to the percentage of the turn completed?

@abidingabi
Copy link
Member

and include code that scales the speed according to the percentage of the turn completed?
This is pretty similar to what a P controller is :). A P controller sets the speed to (target - setpoint) * kP, where kP is a tuned constant, so that you slow down as you approach the target so you do not overshoot. Mentioning full-on PID control would be smart, but I think a P controller is sufficient for this example.

@Krabbenhoft
Copy link
Author

I have worked more on it. What changes would you still like to see?

@abidingabi
Copy link
Member

Most of my suggestions would involve relatively small wording changes. It would be easier to deal with those if you opened a pull request for this, as I could use GitHub review functionality.

@Krabbenhoft
Copy link
Author

#421

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Software Has to do with software Type: New Page
Projects
None yet
Development

No branches or pull requests

2 participants