-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
False negatives #1
Comments
Let me check that 336609055612707510784871435262931004779. I probably think that is because of Number.MAX_SAFE_INTEGER of Javascript. MAX_SAFE_INTEGER: 9007199254740991 or Max Value (Number.MAX_VALUE): 2^1024 - 1, or approximately 1.7976931348623157E+308. The code is not aligned to handle very big or long values; using javascript max values of Number as the base. Let me check if I can accomodate big numbers to assist calculation. I am keeping this issue open meanwhile. |
I can reproduce this with Python 3, which does not have a default integer limit. |
Let me check. I will also check on the BigInt and update the code which just got released in Nodejs as well. https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/BigInt . Any idea Can you share what all tests you are running? |
I don't recall what other tests I used, this was a long time ago. |
The algorithm seems to report that 336609055612707510784871435262931004779 is not a prime number, but it is actually one (confirmed with many different sources).
The text was updated successfully, but these errors were encountered: