Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protocol.tst runs twice, and with negative time #89

Open
olexandr-konovalov opened this issue Jan 20, 2019 · 2 comments
Open

protocol.tst runs twice, and with negative time #89

olexandr-konovalov opened this issue Jan 20, 2019 · 2 comments
Labels
bug: unexpected error A computation runs into an error loop when it should not have bug All bugs should have this label, even if they have a more specific one

Comments

@olexandr-konovalov
Copy link
Member

What happens here in version 1.1? #I No errors detected while testing appears twice and breaks testing scripts, and 2nd time the timing is negative:

============================OUTPUT START==============================
#I  RunPackageTests("jupyterkernel", "1.1", "tst/testall.g", "false");
 ���������������������������   GAP 4.dev of today
 ���  GAP  ���   https://www.gap-system.org
 ���������������������������   Architecture: x86_64-pc-linux-gnu-default64-kv3
 Configuration:  gmp 6.0.0, readline
 Loaded workspace: wsp.g
 Packages:   crypting 0.9, GAPDoc 1.6.2, IO 4.5.4, json 2.0.0, 
             JupyterKernel 1.1, PrimGrp 3.3.2, SmallGrp 1.3, TransGrp 2.0.4, 
             uuid 0.6, ZeroMQInterface 0.11
 Try '??help' for help. See also '?copyright', '?cite' and '?authors'
Architecture: x86_64-pc-linux-gnu-default64-kv3

testing: /circa/scratch/gap-jenkins/workspace/GAP-pkg-update-stable-quicktest/\
GAPCOPTS/64build/GAPGMP/gmp/GAPTARGET/packages/label/kovacs/GAP-pkg-update-sta\
ble-snapshot/pkg/JupyterKernel-1.1/tst/basic.tst
       4 ms (0 ms GC) and 463KB allocated for basic.tst
testing: /circa/scratch/gap-jenkins/workspace/GAP-pkg-update-stable-quicktest/\
GAPCOPTS/64build/GAPGMP/gmp/GAPTARGET/packages/label/kovacs/GAP-pkg-update-sta\
ble-snapshot/pkg/JupyterKernel-1.1/tst/protocol.tst
       1 ms (0 ms GC) and 31.5KB allocated for protocol.tst
-----------------------------------
total         5 ms (0 ms GC) and 494KB allocated
              0 failures in 2 files

#I  No errors detected while testing

    -185 ms (0 ms GC) and 33.1KB allocated for protocol.tst
-----------------------------------
total      -181 ms (0 ms GC) and 496KB allocated
              0 failures in 2 files

#I  No errors detected while testing

============================OUTPUT END================================
@olexandr-konovalov
Copy link
Member Author

olexandr-konovalov commented Jan 21, 2019

Same can be observed on Travis: https://travis-ci.org/gap-packages/JupyterKernel/jobs/479808058 (it does not fail the test and remain unnoticed?). My guess is that because of calling IO_fork(), at some point we have two processes running the same test.

olexandr-konovalov pushed a commit to olexandr-konovalov/JupyterKernel that referenced this issue Feb 19, 2019
Otherwise due to IO_fork() we end up with running test twice.
Fixes gap-packages#89
olexandr-konovalov pushed a commit to olexandr-konovalov/JupyterKernel that referenced this issue Feb 19, 2019
Otherwise due to IO_fork() we end up with running test twice.
Fixes gap-packages#89
@ZachNewbery ZachNewbery added bug All bugs should have this label, even if they have a more specific one bug: unexpected error A computation runs into an error loop when it should not have labels Jul 18, 2021
@olexandr-konovalov
Copy link
Member Author

olexandr-konovalov commented Aug 4, 2021

See also #98 for the fix of the issue with test failure detection on Jenkins.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: unexpected error A computation runs into an error loop when it should not have bug All bugs should have this label, even if they have a more specific one
Projects
None yet
Development

No branches or pull requests

2 participants