Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose everything #7

Open
jkarni opened this issue Feb 26, 2024 · 1 comment
Open

Expose everything #7

jkarni opened this issue Feb 26, 2024 · 1 comment

Comments

@jkarni
Copy link
Contributor

jkarni commented Feb 26, 2024

I tried using cradle to write a helper for limiting system resources with systemd, but ran into the problem that only the Cradle module is exposed, and that doesn't expose the Input class method, or the ProcessConfig type. I think those should be re-exported from somewhere. But more importantly, maybe all modules should be exposed, even if with an Internal name? Otherwise anyone who has an unforeseen use case has to fork the library.

@soenkehahn
Copy link
Contributor

Yeah, I think we should expose all modules. I wouldn't do that in an Internal module, since I think it's fine to just bump the major.minor versions often, at least in the beginning.

For writing your own Input or Output instances you do need to understand some of the internals of cradle so maybe we could have a warning somewhere about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants