Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Namespace collision with migros-promos-backend #4

Open
nicedexter opened this issue Oct 1, 2013 · 1 comment
Open

Namespace collision with migros-promos-backend #4

nicedexter opened this issue Oct 1, 2013 · 1 comment
Assignees

Comments

@nicedexter
Copy link
Contributor

Migros-promos-backend uses a property 'isNew' on a model, which collides with the gm-data one:

@MikeAski

  • This property on gm-data has a public visibility, but I'm not sure it should be as is. Could it be renamed to _isNew if it's not meant to be public?
  • Could we use a meta namespace to distinct object properties from 'meta state' properties, like object.meta.isNew ?
@ghost ghost assigned MikeAski Oct 1, 2013
@MikeAski
Copy link
Contributor

MikeAski commented Oct 1, 2013

isNew is a property based on an ember-data one...
I agree it is quite cavalier from a persistence layer to use such symbols, and also think we should isolate them inside a namespace, like you suggest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants