New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: display warning when there are non-critical errors in the response #7

Open

vladar opened this issue Aug 26, 2020 · 0 comments

Contributor

vladar commented Aug 26, 2020

We should display a warning in the default execute implementation when there are errors along with data:

{
  "errors": [
    {
      "message": "Some non-critical error."
    }
  ],
  "data": {
    "list": []
  },
}

(GraphQL spec treats responses without data key as completely failed. If data key exists in the response, then errors are effectively warnings)

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment