Can't build gatsby v4 site when "--ignore-optional" is used

[pedrolamas]

Preliminary Checks

• This issue is not a duplicate. Before opening a new issue, please search existing issues: https://github.com/gatsbyjs/gatsby/issues
• This issue is not a question, feature request, RFC, or anything other than a bug report directly related to Gatsby. Please post those things in GitHub Discussions: https://github.com/gatsbyjs/gatsby/discussions

Description

I've tried using yarn --ignore-optional --production to install the dependencies of my website and then do yarn build but that failed as it can't find the optional dependency "msgpackr"

Reproduction Link

https://github.com/pedrolamas/pedrolamas.com/tree/gatsby

Steps to Reproduce

1. Clone "gatsby" branch above
2. Run yarn --ignore-optional --production
3. Run yarn build

Expected Result

Build succeeds!

Actual Result

Build fails...

yarn run v1.22.15
$ gatsby build
warning Plugin gatsby-plugin-env-variables is not compatible with your gatsby version 4.1.2 - It requires gatsby@^3.0.0 || ^2.0.0
warning Plugin gatsby-plugin-netlify is not compatible with your gatsby version 4.1.2 - It requires gatsby@^3.0.0
warning Plugin gatsby-plugin-env-variables is not compatible with your gatsby version 4.1.2 - It requires gatsby@^3.0.0 || ^2.0.0
warning Plugin gatsby-plugin-netlify is not compatible with your gatsby version 4.1.2 - It requires gatsby@^3.0.0
success open and validate gatsby-configs, load plugins - 1.746s
success onPreInit - 0.005s
error Cannot find module 'msgpackr'
Require stack:
- D:\Projects\pedrolamas.com\node_modules\lmdb-store\index.js
- D:\Projects\pedrolamas.com\node_modules\gatsby\dist\datastore\lmdb\lmdb-datastore.js
- D:\Projects\pedrolamas.com\node_modules\gatsby\dist\datastore\datastore.js
- D:\Projects\pedrolamas.com\node_modules\gatsby\dist\datastore\index.js
- D:\Projects\pedrolamas.com\node_modules\gatsby\dist\utils\page-data.js
- D:\Projects\pedrolamas.com\node_modules\gatsby\dist\utils\webpack\plugins\static-query-mapper.js
- D:\Projects\pedrolamas.com\node_modules\gatsby\dist\utils\webpack.config.js
- D:\Projects\pedrolamas.com\node_modules\gatsby\dist\commands\build-html.js
- D:\Projects\pedrolamas.com\node_modules\gatsby\dist\commands\build.js
- D:\Projects\pedrolamas.com\node_modules\gatsby-cli\lib\create-cli.js
- D:\Projects\pedrolamas.com\node_modules\gatsby-cli\lib\index.js
- D:\Projects\pedrolamas.com\node_modules\gatsby\dist\bin\gatsby.js
- D:\Projects\pedrolamas.com\node_modules\gatsby\cli.js


  Error: Cannot find module 'msgpackr'
  Require stack:
  - D:\Projects\pedrolamas.com\node_modules\lmdb-store\index.js
  - D:\Projects\pedrolamas.com\node_modules\gatsby\dist\datastore\lmdb\lmdb-datastore.js
  - D:\Projects\pedrolamas.com\node_modules\gatsby\dist\datastore\datastore.js
  - D:\Projects\pedrolamas.com\node_modules\gatsby\dist\datastore\index.js
  - D:\Projects\pedrolamas.com\node_modules\gatsby\dist\utils\page-data.js
  - D:\Projects\pedrolamas.com\node_modules\gatsby\dist\utils\webpack\plugins\static-query-mapper.js
  - D:\Projects\pedrolamas.com\node_modules\gatsby\dist\utils\webpack.config.js
  - D:\Projects\pedrolamas.com\node_modules\gatsby\dist\commands\build-html.js
  - D:\Projects\pedrolamas.com\node_modules\gatsby\dist\commands\build.js
  - D:\Projects\pedrolamas.com\node_modules\gatsby-cli\lib\create-cli.js
  - D:\Projects\pedrolamas.com\node_modules\gatsby-cli\lib\index.js
  - D:\Projects\pedrolamas.com\node_modules\gatsby\dist\bin\gatsby.js
  - D:\Projects\pedrolamas.com\node_modules\gatsby\cli.js

  - loader:933 Function.Module._resolveFilename
    node:internal/modules/cjs/loader:933:15

  - loader:778 Function.Module._load
    node:internal/modules/cjs/loader:778:27

  - loader:1005 Module.require
    node:internal/modules/cjs/loader:1005:19

  - v8-compile-cache.js:159 require
    [pedrolamas.com]/[v8-compile-cache]/v8-compile-cache.js:159:20

  - index.js:211 new LMDBStore
    [pedrolamas.com]/[lmdb-store]/index.js:211:94

  - index.js:1205 open
    [pedrolamas.com]/[lmdb-store]/index.js:1205:3

  - lmdb-datastore.ts:55 getRootDb
    [pedrolamas.com]/[gatsby]/src/datastore/lmdb/lmdb-datastore.ts:55:14

  - lmdb-datastore.ts:66 getDatabases
    [pedrolamas.com]/[gatsby]/src/datastore/lmdb/lmdb-datastore.ts:66:20

  - lmdb-datastore.ts:230 clearIndexes
    [pedrolamas.com]/[gatsby]/src/datastore/lmdb/lmdb-datastore.ts:230:15

  - lmdb-datastore.ts:261 setupLmdbStore
    [pedrolamas.com]/[gatsby]/src/datastore/lmdb/lmdb-datastore.ts:261:3

  - datastore.ts:11 getDataStore
    [pedrolamas.com]/[gatsby]/src/datastore/datastore.ts:11:19

  - datastore.ts:50 callback
    [pedrolamas.com]/[gatsby]/src/datastore/datastore.ts:50:3

  - mett.ts:44 forEach
    [pedrolamas.com]/[gatsby]/src/utils/mett.ts:44:11

  - Set.forEach

  - mett.ts:43 Object.emit
    [pedrolamas.com]/[gatsby]/src/utils/mett.ts:43:17

  - index.ts:153
    [pedrolamas.com]/[gatsby]/src/redux/index.ts:153:11


not finished initialize cache - 0.099s
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Here's a result from github: https://github.com/pedrolamas/pedrolamas.com/runs/4165027185?check_suite_focus=true

Environment

System:
    OS: Windows 10 10.0.22000
    CPU: (12) x64 Intel(R) Core(TM) i7-10750H CPU @ 2.60GHz
  Binaries:
    Node: 16.13.0 - C:\Program Files\nodejs\node.EXE
    Yarn: 1.22.15 - ~\AppData\Roaming\npm\yarn.CMD
    npm: 7.23.0 - C:\Program Files\nodejs\npm.CMD
  Languages:
    Python: 2.7.15
  Browsers:
    Edge: Spartan (44.22000.120.0), Chromium (95.0.1020.44), ChromiumDev (97.0.1069.0)
  npmPackages:
    gatsby: ^4.1.2 => 4.1.2 
    gatsby-plugin-env-variables: ^2.1.0 => 2.1.0 
    gatsby-plugin-eslint: ^4.0.1 => 4.0.1 
    gatsby-plugin-feed-generator: ^2.0.5 => 2.0.5 
    gatsby-plugin-google-gtag: ^4.1.0 => 4.1.0 
    gatsby-plugin-image: ^2.1.0 => 2.1.0 
    gatsby-plugin-manifest: ^4.1.1 => 4.1.1 
    gatsby-plugin-mdx: ^3.1.1 => 3.1.1 
    gatsby-plugin-netlify: ^3.14.0 => 3.14.0 
    gatsby-plugin-offline: ^5.1.1 => 5.1.1 
    gatsby-plugin-react-helmet: ^5.1.0 => 5.1.0 
    gatsby-plugin-robots-txt: ^1.6.14 => 1.6.14 
    gatsby-plugin-sass: ^5.1.1 => 5.1.1 
    gatsby-plugin-sharp: ^4.1.1 => 4.1.1 
    gatsby-plugin-sitemap: ^5.1.1 => 5.1.1 
    gatsby-plugin-twitter: ^4.1.1 => 4.1.1 
    gatsby-remark-acronyms: ^1.1.4 => 1.1.4 
    gatsby-remark-copy-linked-files: ^5.1.0 => 5.1.0 
    gatsby-remark-images: ^6.1.1 => 6.1.1 
    gatsby-remark-responsive-iframe: ^5.1.0 => 5.1.0 
    gatsby-remark-smartypants: ^5.1.0 => 5.1.0 
    gatsby-source-filesystem: ^4.1.0 => 4.1.0 
    gatsby-transformer-sharp: ^4.1.0 => 4.1.0 
    gatsby-transformer-yaml: ^4.1.0 => 4.1.0 
  npmGlobalPackages:
    gatsby-cli: 4.0.0

Config Flags

No response

[LekoArts]

The dependency is marked as optional as you can also use cbor-x instead. But by default msgpackr is used (and there's no reason to switch) so the npm package is necessary.

https://github.com/DoctorEvidence/lmdb-store/blob/11ec0f24bcfed9bf1dbce80c064eec51f311a963/index.js#L211

If you want to use the --ignore-optional you'll have to add it to the dependencies yourself then.

[pedrolamas]

Indeed, that matches what I found, but given that by msgpackr is used by default (and I'm assuming here there is no direct way of changing it), shouldn't that be a dependency in Gatsby instead?

[LekoArts]

I'd say in that case it should probably be a direct dependency on https://github.com/DoctorEvidence/lmdb-store - feel free to open an issue there and ask about the intention behind it :)