Onzen (Salt Water System) Support

[feens]

I was poking around in the code and other issues/requests seeing if it would be possible to view/control the salt water system on my spa. It looks like it may be possible, but I'm not 100% sure what to look for. I notice it listed in both Output connections are and Actual connections are in the logs, and tried capturing changing some settings while logging as well. I'm a Ruby developer by day but don't have much experience in Python (but I'm sure I could figure it out)...just not sure what to look for or where to start in terms of parsing messages and building a device handler for it, so some guidance would be helpful.

[gazoodle]

If the def _scan_outputs(self) function in GeckoAsyncFacade has identified a user demandable feature from the spa pack then you can use that keyed entity to capture an accessor from the spa to control that entity.

If the entity is an "on/off" kind of thing (and looking in the SpaPackStruct.xml, it appears to be so), then it will be pretty straightforward to extend the function to add this to the devices that are controllable.

Personally, I'd duplicate the functionality for GeckoLight (create a new class, duplicate the code where it gets initialized in the _scan_outputs function so that you've added the functionality to the facade class.

Then you need to move over to the HA integration and add the control, again this ought to be as easy as copying the code for the lights.

I don't have time at present to do this, but am happy to have it added to the backlog if it seems like too much to tweak for you?

[patrikrask]

Hi Thanks again, I managed to use the rest api in homeassistant to do this. I will live with this and maybe I try again later without HA as I like to have full control over important things as heating etc here in the north Thanks again Patrik Den fre 14 okt. 2022 kl 10:23 skrev gazoodle ***@***.***>:

…

If the def _scan_outputs(self) function in GeckoAsyncFacade has identified a user demandable feature from the spa pack then you can use that keyed entity to capture an accessor from the spa to control that entity. If the entity is an "on/off" kind of thing (and looking in the SpaPackStruct.xml, it appears to be so), then it will be pretty straightforward to extend the function to add this to the devices that are controllable. Personally, I'd duplicate the functionality for GeckoLight (create a new class, duplicate the code where it gets initialized in the _scan_outputs function so that you've added the functionality to the facade class. Then you need to move over to the HA integration and add the control, again this ought to be as easy as copying the code for the lights. I don't have time at present to do this, but am happy to have it added to the backlog if it seems like too much to tweak for you? — Reply to this email directly, view it on GitHub <#32 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AC4F77JVJO4UWGPLYSB4BV3WDEJ6RANCNFSM6AAAAAARBTIH6I> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[feens]

@gazoodle I'll have to checks but I don't think it's an on/off. It should be more like the energy settings, where it has a start/time/frequency (aka 4hrs 4 times a day). Not that I have much free time, but I'm happy to plug away at a PR as I have some time, unless you're able to get to it first.

[feens]

@gazoodle curious if you're around at all to answer a few questions around this. I've started to dig into this now, and I'm also looking to fix the deprecations.