Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mobile view and add mobile media queries. #10

Open
gbowne1 opened this issue Feb 1, 2023 · 1 comment
Open

Fix mobile view and add mobile media queries. #10

gbowne1 opened this issue Feb 1, 2023 · 1 comment
Labels
bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers hacktoberbest The hacktoberfest label help wanted Extra attention is needed question Further information is requested

Comments

@gbowne1
Copy link
Owner

gbowne1 commented Feb 1, 2023

My desktop device is 1920x1080 but the CSS viewport is 1884px x 905px.

I always expect my topbar/topnav on desktop to be 1884x60 when inspecting it in console.

I expect CSS breakpointsin any media queries to be:

1920x1080 (Desktops)
1366x768 (Laptops)
375x667 (Some mobile and tablet)
360x640 (Other mobile and tablet)

I expect the footer to be no more than 500px high, but my footer only needs to contain my social icons and copyright and quick contact links so can be very short in height.

@gbowne1 gbowne1 added bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers question Further information is requested labels Mar 19, 2023
@k-deepak04 k-deepak04 removed their assignment Apr 18, 2023
@gbowne1
Copy link
Owner Author

gbowne1 commented Apr 19, 2023

I think the media queries would be:

@media screen and (max-width: 1366px) and (max-height: 768px) {
/* Your styles for 1366px x 768px laptop */
}

@media screen and (max-width: 375px) and (max-height: 667px) {
/* Your styles for 375px x 667px Apple iPhone */
}

@media screen and (max-width: 360px) and (max-height: 640px) {
/* Your styles for 360px x 640px Android phone */
}

@gbowne1 gbowne1 added the hacktoberbest The hacktoberfest label label Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers hacktoberbest The hacktoberfest label help wanted Extra attention is needed question Further information is requested
Development

No branches or pull requests

2 participants