Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically add missing requirements to decorators #381

Open
rg936672 opened this issue Aug 21, 2024 · 0 comments
Open

Automatically add missing requirements to decorators #381

rg936672 opened this issue Aug 21, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@rg936672
Copy link
Contributor

What's the new feature?

BinaryClassification and CategoricalClassification both require other decorators to be applied before them, and will throw a TypeError if this is not the case. It would be more ergonomic for users if this was done automatically if the decorators aren't already provided.

What value does this add?

Ease of use for client code.

Is there an alternative you've considered?

Leaving it as is.

Additional context

Came up in #379 - that PR introduces a similar mechanism but only within test_decorator_combinations.

We should also add a way of disabling this automatic addition of required decorators, and also a way of disabling the requirement checks, since clients may want to implement their own versions of the required decorators instead. These disables should be signposted with appropriate warnings, though!

@rg936672 rg936672 added enhancement New feature or request new Something yet to be discussed by development team labels Aug 21, 2024
@tp832944 tp832944 removed the new Something yet to be discussed by development team label Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants