You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, InertKernelModel returns a DummyKernelDistribution when called. However, its superclass (ExactGPModel) returns a MultivariateNormal, and DummyKernelDistribution is not a subclass of MultivariateNormal or even of Distribution. This violates the Liskov substitution principle.
Implement all required methods to make DummyKernelDistribution inherit from Distribution, and change the type hint on ExactGPModel.forward to indicate that it returns a Distribution (Possibly also change other code downstream of this to reflect this change as well.)
The text was updated successfully, but these errors were encountered:
What's the issue?
Currently,
InertKernelModel
returns aDummyKernelDistribution
when called. However, its superclass (ExactGPModel
) returns aMultivariateNormal
, andDummyKernelDistribution
is not a subclass ofMultivariateNormal
or even ofDistribution
. This violates the Liskov substitution principle.Implement all required methods to make
DummyKernelDistribution
inherit fromDistribution
, and change the type hint onExactGPModel.forward
to indicate that it returns aDistribution
(Possibly also change other code downstream of this to reflect this change as well.)The text was updated successfully, but these errors were encountered: