Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make DummyKernelDistribution actually inherit from Distribution #394

Open
rg936672 opened this issue Sep 2, 2024 · 0 comments
Open

Make DummyKernelDistribution actually inherit from Distribution #394

rg936672 opened this issue Sep 2, 2024 · 0 comments

Comments

@rg936672
Copy link
Contributor

rg936672 commented Sep 2, 2024

What's the issue?

Currently, InertKernelModel returns a DummyKernelDistribution when called. However, its superclass (ExactGPModel) returns a MultivariateNormal, and DummyKernelDistribution is not a subclass of MultivariateNormal or even of Distribution. This violates the Liskov substitution principle.

Implement all required methods to make DummyKernelDistribution inherit from Distribution, and change the type hint on ExactGPModel.forward to indicate that it returns a Distribution (Possibly also change other code downstream of this to reflect this change as well.)

@rg936672 rg936672 added the new Something yet to be discussed by development team label Sep 2, 2024
@bc294725 bc294725 removed the new Something yet to be discussed by development team label Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants