Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Iterative KH padding invariant #984

Closed
qh681248 opened this issue Feb 21, 2025 · 1 comment · May be fixed by #983
Closed

Make Iterative KH padding invariant #984

qh681248 opened this issue Feb 21, 2025 · 1 comment · May be fixed by #983
Labels
bug Something isn't working new Something yet to be discussed by development team

Comments

@qh681248
Copy link
Contributor

What's the problem?

Currently, unit tests do not pass when Iterative KH is set to be padding invariant and probabilistic = True but passes otherwise, investigate what is causing the unit tests to fail? (Might potentially be fixed by #983 )

How can we reproduce the issue?

Add Padding Invariant solver to Iterative KH class definition and rerun the unit test

Python version

3.13

Package version

0.4.0

Operating system

windows

Other packages

No response

Relevant log output

@qh681248 qh681248 added bug Something isn't working new Something yet to be discussed by development team labels Feb 21, 2025
@rg936672 rg936672 linked a pull request Feb 28, 2025 that will close this issue
9 tasks
@gw265981
Copy link
Contributor

gw265981 commented Mar 3, 2025

Iterative KH implementation superseded by #977.

@gw265981 gw265981 closed this as completed Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working new Something yet to be discussed by development team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants