New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong domain check #3

Open

saur0n opened this issue Dec 6, 2018 · 2 comments

saur0n commented Dec 6, 2018 •

edited

Loading

Please check if this domain check is correct:

if (hand->fw_args.phm_div > 32 || hand->fw_args.ext_clk < 2) {

The text was updated successfully, but these errors were encountered:

Collaborator

pcercuei commented Dec 9, 2018

Looks correct to me. What's wrong with it?

Author

saur0n commented Dec 9, 2018 •

edited

Loading

Should it be

if (hand->fw_args.phm_div > 32 || hand->fw_args.phm_div < 2) {

? Because ext_clk was already checked earlier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment