Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xml invalid atom statement #190

Open
mrwerdo opened this issue Feb 13, 2025 · 1 comment
Open

xml invalid atom statement #190

mrwerdo opened this issue Feb 13, 2025 · 1 comment

Comments

@mrwerdo
Copy link

mrwerdo commented Feb 13, 2025

Hi there,

The swordv2 interface returns invalid XML because this constructor is called incorrectly.

<http://purl.org/net/sword/terms/depositedOn xmlns="">2025-02-11T05:22:41</http://purl.org/net/sword/terms/depositedOn>

compared with

<depositedOn xmlns="http://purl.org/net/sword/terms/">2025-02-11T23:34:44</depositedOn>

I don't know how to reproduce this short of calling it from DSpace, which is the product I'm using. Please see this issue.

@pdurbin
Copy link
Member

pdurbin commented Feb 14, 2025

Hmm, I see in DSpace you use statement.setOriginalDeposits (which will end up hitting the constructor you mentioned): https://github.com/DSpace/DSpace/blob/19aa8bcce946e8cfcd4ea963cab386d1460f2593/dspace-swordv2/src/main/java/org/dspace/sword2/GenericStatementDisseminator.java#L50

From a quick look at our code, we don't seem to use this "original deposits" functionality in Dataverse. I'm not even sure what it's for. I also poked around with out tests at https://github.com/IQSS/dataverse/blob/v6.5/src/test/java/edu/harvard/iq/dataverse/api/SwordIT.java and I'm getting valid XML.

We forked this library from https://github.com/swordapp/JavaServer2.0 and don't know all the functionality.

You are very welcome to create a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants