Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3 tests failing #511

Open
fedeinthemix opened this issue Nov 13, 2024 · 3 comments
Open

3 tests failing #511

fedeinthemix opened this issue Nov 13, 2024 · 3 comments

Comments

@fedeinthemix
Copy link

Describe the bug

Running the tests I get the following 3 errors:

=========================== short test summary info ============================
FAILED tests/test_pdk.py::test_merge_read_shapes - AttributeError: 'YAML' object has no attribute 'dumps'. Did you mean: 'dump'?
FAILED tests/test_pdk.py::test_merge_read_instances - AttributeError: 'YAML' object has no attribute 'dumps'. Did you mean: 'dump'?
FAILED tests/test_pdk.py::test_merge_properties - AttributeError: 'YAML' object has no attribute 'dumps'. Did you mean: 'dump'?
================== 3 failed, 1453 passed in 98.46s (0:01:38) ===================

Expected behavior
I expect all tests to pass.

Desktop (please complete the following information):

  • OS: NixOS
  • Browser Firefox
  • Version 132.0.1

Additional context

I'm using:

  • python 3.12.7
  • kfactory 0.21.7
@sebastian-goeldi
Copy link
Collaborator

sebastian-goeldi commented Nov 13, 2024

Would it be possible to get the detailed error parts of pytest?

I know what the error is (a YAML from ruamel.yaml without the string extension loaded in, i.e. no YAML(typ=["str"])), but I am a bit confused why for these tests it's reaching a point where it would need the yaml dumper.

@fedeinthemix
Copy link
Author

Here the full build log including tests

kfactory_tests.log

@sebastian-goeldi
Copy link
Collaborator

sebastian-goeldi commented Nov 13, 2024

Ah, I think I know where the error is coming from.

'kfactory:ports:1' MetaInfo differs between existing '{'cross_section': 'eac2d666_1000', 'info': {}, 'name': 'o2', 'port_type': 'optical', 'trans': <klayout.dbcore.Trans object at 0x7ffe95b63410>}' and loaded '{'cross_section': '5d8f70ac_1000', 'info': {}, 'name': 'o2', 'port_type': 'optical', 'trans': <klayout.dbcore.Trans object at 0x7ffe95b634a0>}'

This tells me that the hashes do not evaluate to the same value. I suspect it's the LayerInfo object. What I don't understand is why it works on debian (and arch to my knowledge) with no problem

Nvm it must be the cross_section. I don't fully understand yet why you are getting different cross sections for the two

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants