You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I've been on your FOSDEM talk about the project. It's great that you finally open-sourced your work!
I noticed that in the Cargo.toml file Link-Time Optimization (LTO) for the project is not enabled. I suggest switching it on since it will reduce the binary size (always a good thing to have) and will likely improve the application's performance. If you want to read more about LTO and its possible modes, I recommend starting from this Rustc documentation.
I think you can enable LTO only for the Release builds so as not to sacrifice the developers' experience while working on the project, since LTO consumes an additional amount of time to finish the compilation routine. In this case, we can create a dedicated [profile.optimized-dev] profile where LTO will be disabled (so developers experience will not be affected). If we enable it on the Cargo profile level for the Release profile, users, who install the application with cargo install, will get the LTO-optimized version of the app "automatically". E.g., check cargo-outdated Release profile. You also could be interested in other optimization options like codegen-units = 1 - it also brings improvements over the current defaults.
Basically, it can be enabled with the following lines:
[profile.release]
codegen-units = 1
lto = true
I have made quick tests (AMD Ryzen 5900x, Fedora 41, Rust 1.84.1, the latest version of the project at the moment, cargo build --release command) - here are the results.
Release (current default) binary sizes:
tuxtape-server: 11 Mib
tuxtape-dashboard: 13 Mib
tuxtape-kernel-builder: 7.5 Mib
tuxtape-cve-parser: 6.7 Mib
Release + codegen-units = 1 + Fat LTO:
tuxtape-server: 7.1 Mib
tuxtape-dashboard: 8.5 Mib
tuxtape-kernel-builder: 4.7 Mib
tuxtape-cve-parser: 5.9 Mib
Clean build times:
Release (current default): 33s
Release + codegen-units = 1 + Fat LTO: 72s
I understand that the current project state is a PoC. I suggest you enabling these optimizations (and probably some others) as earlier as possible so all future tuxtape versions like hardened PoC, MVP, an actual product, etc. will be optimized from the day one.
Thank you.
The text was updated successfully, but these errors were encountered:
Thank you very much for your contribution! (You are the first public contributor to TuxTape, so thank you again for your early support of this project.) This issue is very well researched and written, and this is a prime example of the community engagement we are seeking.
It seems like the changes you're suggesting will more than double compilation time for ~35% reduction in binary size on average, and the binaries already aren't too large, but you are claiming an improvement in performance which may be helpful once the project expands. Right now, there are optimizations needed in the code (I've seen likely higher than necessary CPU utilization in the dashboard for example) that are likely bigger performance bottlenecks which wouldn't affect compile time. Regardless, I don't want to dismiss any suggestions on optimization without benchmarking first.
For now, I'm going to leave this issue open as this is something we certainly should consider down the line. Once we shift into MVP and performance metrics are being benchmarked, I'll make sure to benchmark these changes and see if the tradeoffs are worthwhile.
Hi!
I've been on your FOSDEM talk about the project. It's great that you finally open-sourced your work!
I noticed that in the
Cargo.toml
file Link-Time Optimization (LTO) for the project is not enabled. I suggest switching it on since it will reduce the binary size (always a good thing to have) and will likely improve the application's performance. If you want to read more about LTO and its possible modes, I recommend starting from this Rustc documentation.I think you can enable LTO only for the Release builds so as not to sacrifice the developers' experience while working on the project, since LTO consumes an additional amount of time to finish the compilation routine. In this case, we can create a dedicated
[profile.optimized-dev]
profile where LTO will be disabled (so developers experience will not be affected). If we enable it on the Cargo profile level for the Release profile, users, who install the application withcargo install
, will get the LTO-optimized version of the app "automatically". E.g., checkcargo-outdated
Release profile. You also could be interested in other optimization options likecodegen-units = 1
- it also brings improvements over the current defaults.Basically, it can be enabled with the following lines:
I have made quick tests (AMD Ryzen 5900x, Fedora 41, Rust 1.84.1, the latest version of the project at the moment,
cargo build --release
command) - here are the results.Release (current default) binary sizes:
tuxtape-server
: 11 Mibtuxtape-dashboard
: 13 Mibtuxtape-kernel-builder
: 7.5 Mibtuxtape-cve-parser
: 6.7 MibRelease +
codegen-units = 1
+ Fat LTO:tuxtape-server
: 7.1 Mibtuxtape-dashboard
: 8.5 Mibtuxtape-kernel-builder
: 4.7 Mibtuxtape-cve-parser
: 5.9 MibClean build times:
codegen-units = 1
+ Fat LTO: 72sI understand that the current project state is a PoC. I suggest you enabling these optimizations (and probably some others) as earlier as possible so all future
tuxtape
versions like hardened PoC, MVP, an actual product, etc. will be optimized from the day one.Thank you.
The text was updated successfully, but these errors were encountered: