Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extended deprecated SerenityReporter class should be replaced with SerenityReporterParallel #11

Open
svbergmann opened this issue Sep 5, 2024 · 5 comments
Assignees

Comments

@svbergmann
Copy link

Tiger uses the TigerSerenityReporterPlugin class which extends the SerentiyReporter class from Cucumber. This class is deprecated since "4.0.50" and should be replaced by io.cucumber.core.plugin.SerenityReporterParallel.
There should not be issues which replacing those classes because it seems that they just replaced the class and gave the newer class some new methods and changed some visibilities.

@eitzenbe
Copy link

eitzenbe commented Sep 5, 2024

Hi Sven,
We appreciate your feedback. AS of now Tiger is based on Serenity 4.1.14 and is not supporting parallel test execution (ALAS you might try to run it). We are in the process of upgrading to Serenity 4.2.x later this year (October rings a bell) in which process we might also adapt the plugin dependency. Do you want to share more details as to why you woul dneed that change? br Thomas

@svbergmann
Copy link
Author

Hi Thomas,
Thanks for this very quick answer. I think that parallel testing would be a huge benefit for people using tiger as their testing framework. I came accross this deprecation note while debugging code and I just thought it would be nice to let you know that there is a newer class available which is not deprecated.
Kind regards
Sven

@eitzenbe
Copy link

eitzenbe commented Sep 5, 2024

okidoki, I will look into this, maybe we can even earlier migrate ;) Would be cool to hear more about how you are using Tiger... Feel free to drop me a note at [email protected] ;)

@eitzenbe
Copy link

eitzenbe commented Sep 5, 2024

TGR-1548 is the ticket to look out for, but it needs a released 4.2.1 of Serenity as the plugin has reverted the protected scope of methods we need to overwrite/access

@eitzenbe
Copy link

eitzenbe commented Sep 8, 2024

PR for serenity is out in the wild: serenity-bdd/serenity-core#3528

@eitzenbe eitzenbe self-assigned this Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants