From 9d4b37f35decb7315e6760e4005af07d827667fb Mon Sep 17 00:00:00 2001
From: remy siminel <remysben@gmail.com>
Date: Wed, 10 Jul 2024 17:38:08 +0200
Subject: [PATCH 1/4] use ngValue to bind group names

---
 manager2/src/app/user/user.component.html | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/manager2/src/app/user/user.component.html b/manager2/src/app/user/user.component.html
index 09356de3..a75e84f5 100644
--- a/manager2/src/app/user/user.component.html
+++ b/manager2/src/app/user/user.component.html
@@ -140,7 +140,7 @@ <h4>Information</h4>
                     <div class="col-4 col-form-label"></div>
                     <div class="col-6">
                       <select [(ngModel)]="user.group" [ngModelOptions]="{standalone: true}" class="form-control">
-                        <option *ngFor="let group of groups" [value]="group.name">{{group.new ? group.name + " (new group)" : group.name}}</option>
+                        <option *ngFor="let group of groups" [ngValue]="group.name">{{group.new ? group.name + " (new group)" : group.name}}</option>
                       </select>
                       <div class="alert alert-success" *ngIf="grp_success_msg">{{grp_success_msg}}</div>
                       <div class="alert alert-danger" *ngIf="grp_err_msg">{{grp_err_msg}}</div>

From 89ec05d5b46a943427bcdcbf68c2ec5767e07984 Mon Sep 17 00:00:00 2001
From: remy siminel <remysben@gmail.com>
Date: Fri, 12 Jul 2024 11:41:51 +0200
Subject: [PATCH 2/4] update changelog

---
 CHANGELOG.md | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 23ce7460..6dfa8865 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -2,13 +2,13 @@
 
 ## 1.4.30 (TBA)
 
-* Added 'End date' to the project request page
+* Add 'End date' to the project request page
 * Set 'description' as a required field in the project request page and set a minimal length of 30 char
-* Added a link to user profile on admin panels -> projects pending table
-* Added 'Extend' button for admins to extend active TPs
-* Prevented retroactive TP reservations
-* Added checks to user registration form, the user information update form and the TP reservation form
-* Added back button from single project view
+* Add a link to user profile on admin panels -> projects pending table
+* Add 'Extend' button for admins to extend active TPs
+* Add checks to user registration form, the user information update form and the TP reservation form
+* Add back button from single project view
+* Fix newly created group selection bug
 
 ## 1.4.29
 

From eb881c791092adc6a31b00784daf814989db0936 Mon Sep 17 00:00:00 2001
From: remy siminel <remysben@gmail.com>
Date: Fri, 12 Jul 2024 11:48:28 +0200
Subject: [PATCH 3/4] fix

---
 CHANGELOG.md | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 426f80b2..5ec0e34d 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -2,6 +2,11 @@
 
 ## 1.4.30 (TBA)
 
+* Added a project.terms_and_conditions_hds setting in the config:
+  If true:
+    "Ask Admin" button to submit project creation form became available after 'project name' and 'expiration date' are filled, 'project description' is at least 30 char and a checkbox appears and 'terms and conditions hds' should also be checked
+  If false:
+    "Ask Admin" button to submit project creation form became available after 'project name' and 'expiration date' are filled, 'project description' is at least 30 char, no consent checkbox
 * Add 'End date' to the project request page
 * Set 'description' as a required field in the project request page and set a minimal length of 30 char
 * Add a link to user profile on admin panels -> projects pending table

From c1ce1d7ccdde995920e4c9d79aba7f99ae1622b3 Mon Sep 17 00:00:00 2001
From: remy siminel <remysben@gmail.com>
Date: Fri, 12 Jul 2024 11:50:53 +0200
Subject: [PATCH 4/4] fix

---
 CHANGELOG.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 5ec0e34d..d003a4c9 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -2,7 +2,7 @@
 
 ## 1.4.30 (TBA)
 
-* Added a project.terms_and_conditions_hds setting in the config:
+* Added a `project.terms_and_conditions_hds` setting in the config:
   If true:
     "Ask Admin" button to submit project creation form became available after 'project name' and 'expiration date' are filled, 'project description' is at least 30 char and a checkbox appears and 'terms and conditions hds' should also be checked
   If false: