Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why it was removed dependence on csv-parser? #15

Open
bigslycat opened this issue Nov 27, 2016 · 2 comments
Open

Why it was removed dependence on csv-parser? #15

bigslycat opened this issue Nov 27, 2016 · 2 comments

Comments

@bigslycat
Copy link
Contributor

bigslycat commented Nov 27, 2016

Excuse me, but why 0f8bd34? I think, if CSV/TSV processing code is encapsulated in a separate package, it is more rational. 17 third party developers csv-parser will remove low-level load with the current project. After geonames-stream is essentially a high-level abstraction of the process CSV/TSV parsing. Why duplicate the logic that has already been implemented? I propose that this relationship again, and ready to undertake it.

@bigslycat bigslycat changed the title Why it was removed dependence on csv-parser? 0f8bd34 Why it was removed dependence on csv-parser? Nov 27, 2016
@missinglink
Copy link
Member

hi @bigslycat, it was over 2 years ago and I really don't remember why. It's possible that at that time the library didn't work as expected.

if you would like to open a PR to add it back and delete the internal parser then I'd be happy to review it.

@bigslycat
Copy link
Contributor Author

Excellent. I'll do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants