Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server/model dir should be emptied after each build (?) #5

Open
manosplitsis opened this issue Feb 24, 2022 · 2 comments
Open

server/model dir should be emptied after each build (?) #5

manosplitsis opened this issue Feb 24, 2022 · 2 comments

Comments

@manosplitsis
Copy link

manosplitsis commented Feb 24, 2022

When building a new docker image, the model directory is copied to server/model, but the user has to remove the contents manually to build from a different model dir

@manosplitsis manosplitsis changed the title server/model dir should be emptied server/model dir should be emptied after each build (?) Feb 24, 2022
@georgepar
Copy link
Owner

Yes that's by design. Imagine the case where actually the user doesn't have a backup of the model and the script goes on to delete it. Its better be annoying and make the user make the conscious decision to delete their model.

We could include a cmd line flag (-y) to bypass this, or make the script ask for permission interactively. Feel free to post a pr

@georgepar
Copy link
Owner

TODO: Add a flag to remove old models during model building

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants