Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable PR merge squashing #225

Open
nyurik opened this issue Jul 31, 2024 · 2 comments
Open

Enable PR merge squashing #225

nyurik opened this issue Jul 31, 2024 · 2 comments

Comments

@nyurik
Copy link
Member

nyurik commented Jul 31, 2024

The automated merge-queue system keeps all original revisions of the PR. This polutes git history without much value -- if needed, the individual PR steps can still be viewed in the PR itself. Can we enable squashing somehow?

@michaelkirk
Copy link
Member

michaelkirk commented Jul 31, 2024

Semantic commits are wonderful. For example you can separate out small refactors from feature changes.

A squashed commit is better than a ton of garbage commits.

I don't want to consider github.com as a source of record any more than necessary.

My preference is that it be possible, but not required, to squash commits.

@nyurik
Copy link
Member Author

nyurik commented Jul 31, 2024

as long as we can use it (possibly by default unless explicitly ask not to), works for me. The problem is that ever since we enabled merge pipeline on this repo, the dropdown for the "merge" button no longer has any options...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants