followups

Sources/Sentry/SentryClient.m

@@ -617,7 +617,7 @@ - (void)captureFeedback:(SentryFeedback *)feedback withScope:(SentryScope *)scop
                              alwaysAttachStacktrace:NO];
     SentryTraceContext *traceContext = [self getTraceStateWithEvent:preparedEvent withScope:scope];
     NSArray *attachments = [[self attachmentsForEvent:preparedEvent scope:scope]
-        arrayByAddingObjectsFromArray:[feedback attachments]];
+                            arrayByAddingObjectsFromArray:[feedback attachmentsForEnvelope]];
 
     [self.transportAdapter sendEvent:preparedEvent
                         traceContext:traceContext

Sources/Swift/Integrations/UserFeedback/SentryFeedback.swift

@@ -15,14 +15,14 @@ class SentryFeedback: NSObject {
         case custom
     }
 
-    var name: String?
-    var email: String?
-    var message: String
-    var source: SentryFeedbackSource
+    private var name: String?
+    private var email: String?
+    private var message: String
+    private var source: SentryFeedbackSource
     let eventId: SentryId
 
     /// Data objects for any attachments. Currently the web UI only supports showing one attached image, like for a screenshot.
-    var attachments: [Data]?
+    private var attachments: [Data]?
 
     /// The event id that this feedback is associated with, like a crash report.
     var associatedEventId: SentryId?

Tests/SentryTests/Integrations/Feedback/SentryFeedbackTests.swift

@@ -29,15 +29,15 @@ class SentryFeedbackTests: XCTestCase {
     }
 
     func testSerializeWithAllFields() throws {
-        let sut = SentryFeedback(message: "Test feedback message", name: "Test feedback provider", email: "[email protected]", screenshot: Data())
+        let sut = SentryFeedback(message: "Test feedback message", name: "Test feedback provider", email: "[email protected]", attachments: [Data()])
 
         let serialization = sut.serialize()
         XCTAssertEqual(try XCTUnwrap(serialization["message"] as? String), "Test feedback message")
         XCTAssertEqual(try XCTUnwrap(serialization["name"] as? String), "Test feedback provider")
         XCTAssertEqual(try XCTUnwrap(serialization["contact_email"] as? String), "[email protected]")
         XCTAssertEqual(try XCTUnwrap(serialization["source"] as? String), "widget")
 
-        let attachments = sut.attachments()
+        let attachments = sut.attachmentsForEnvelope()
         XCTAssertEqual(attachments.count, 1)
         XCTAssertEqual(try XCTUnwrap(attachments.first).filename, "screenshot.png")
         XCTAssertEqual(try XCTUnwrap(attachments.first).contentType, "application/png")
@@ -52,7 +52,7 @@ class SentryFeedbackTests: XCTestCase {
         XCTAssertNil(serialization["contact_email"])
         XCTAssertEqual(try XCTUnwrap(serialization["source"] as? String), "widget")
 
-        let attachments = sut.attachments()
+        let attachments = sut.attachmentsForEnvelope()
         XCTAssertEqual(attachments.count, 0)
     }