Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Sentry.LoggerHandler.capture_log_messages to true by default #855

Open
PJUllrich opened this issue Feb 3, 2025 · 2 comments
Open

Set Sentry.LoggerHandler.capture_log_messages to true by default #855

PJUllrich opened this issue Feb 3, 2025 · 2 comments

Comments

@PJUllrich
Copy link

PJUllrich commented Feb 3, 2025

Hallo Guten Tag,

I'd like to suggest that you set the capture_log_messages option of the Sentry.LoggerHandler to true by default. Right now, it's set to false which means that calls to Logger.error are not Sent-ry'd (get it?!) by default which might cause:

Image

I think setting capture_log_messages: true together with level: error might be a safe default here.

Alternatively, it might also be enough to mention this configuration in your setup instructions.

@solnic
Copy link
Collaborator

solnic commented Feb 3, 2025

Personally, I am not so sure about changing the default, because if we suddenly start sending by default, error rates may go up for some folks and that would also be a CONFUSION OF DA HIGHEST ORDA. We should definitely improve info about this in the setup guides/docs.

@PJUllrich
Copy link
Author

Sounds sensible to me. I just wanted to point out that this might be an important enough configuration to put in the setup docs.

@getsantry getsantry bot moved this to Waiting for: Product Owner in GitHub Issues with 👀 3 Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Waiting for: Product Owner
Development

No branches or pull requests

3 participants