-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nx with @nx/angular:browser-esbuild and plugin @sentry/esbuild-plugin doesn't work #676
Comments
Hi, thanks for reporting! I guess this means that something changed with Nx or Angular recently that makes this no longer work correctly. In fact, I'm thinking if we should simply remove the webpack and esbuild guides for Angular, given that they cause more issues and require more configuration than Sentry CLI. The only downside is PWAs/service workers not being happy about modifying source contents post-build (like when injecting the debugId). |
Hm, if that breaks PWA then this would be a pretty big problem. Any way to get PWA working with Sentry CLI? |
Yup, it can be worked around as documented here it's just something that came up in the past and we didn't have an answer for this before discovering the |
Thanks @Lms24. As long as there is a fully featured alternative then its fine. |
Environment
"@nx/angular": "20.2.1",
"@sentry/angular": "^9.1.0",
"@sentry/esbuild-plugin": "^3.1.2",
Steps to Reproduce
Follow the steps outlined in https://docs.sentry.io/platforms/javascript/guides/angular/sourcemaps/uploading/angular-nx/#esbuild to create sourcemaps and add the sentry esbuilder plugin.
Expected Result
When running "nx build" I would expect to see the created sourcemaps in the dist folder and have the sentry plugin inject the debugid info and upload them.
Actual Result
Sentry is reporting that it is unable to determin the debug ID from bundle for all .js files:
When I remove the sentry plugin and only run nx build to create the application and then
sentry-cli sourcemaps inject --org xxxxx --project test ./dist
it works fine. So something seems to be broken with the combination of nx/esbuild-pluginThe text was updated successfully, but these errors were encountered: