From 20a8d8c9bdcbda057252e657a3281d36f1de979a Mon Sep 17 00:00:00 2001 From: Francesco Novy Date: Tue, 13 Aug 2024 16:30:42 +0200 Subject: [PATCH 1/2] ci: Fail on cache restore where necessary (#13349) This should at least make it clearer why/where stuff is failing. --- .github/workflows/build.yml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index cd5b7a7447ec..a956f585b414 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -977,6 +977,7 @@ jobs: with: path: ${{ github.workspace }}/packages/*/*.tgz key: ${{ env.BUILD_CACHE_TARBALL_KEY }} + fail-on-cache-miss: true - name: Install Playwright uses: ./.github/actions/install-playwright @@ -1076,6 +1077,7 @@ jobs: with: path: ${{ github.workspace }}/packages/*/*.tgz key: ${{ env.BUILD_CACHE_TARBALL_KEY }} + fail-on-cache-miss: true - name: Install Playwright uses: ./.github/actions/install-playwright @@ -1446,6 +1448,7 @@ jobs: path: ${{ env.CACHED_DEPENDENCY_PATHS }} key: ${{ needs.job_build.outputs.dependency_cache_key }} enableCrossOsArchive: true + fail-on-cache-miss: true - name: Restore build cache uses: actions/cache/restore@v4 @@ -1454,6 +1457,7 @@ jobs: path: ${{ env.CACHED_BUILD_PATHS }} key: ${{ needs.job_build.outputs.dependency_cache_key }} enableCrossOsArchive: true + fail-on-cache-miss: true - name: Configure safe directory run: | From 479668b6906abe75fd2f96091d0e070965082ee7 Mon Sep 17 00:00:00 2001 From: Francesco Novy Date: Tue, 13 Aug 2024 16:30:58 +0200 Subject: [PATCH 2/2] ci: Automatically clear caches for closed PRs (#13354) Taken from https://github.com/actions/cache/blob/main/tips-and-workarounds.md#force-deletion-of-caches-overriding-default-cache-eviction-policy. Caches are per-branch, so if a PR is closed we do not need to keep any caches for that branch around anymore. This PR adds automation to do just that. --- .github/workflows/cleanup-pr-caches.yml | 38 +++++++++++++++++++++++++ 1 file changed, 38 insertions(+) create mode 100644 .github/workflows/cleanup-pr-caches.yml diff --git a/.github/workflows/cleanup-pr-caches.yml b/.github/workflows/cleanup-pr-caches.yml new file mode 100644 index 000000000000..5ebd0b7aad9d --- /dev/null +++ b/.github/workflows/cleanup-pr-caches.yml @@ -0,0 +1,38 @@ +name: "Automation: Cleanup PR caches" +on: + pull_request: + types: + - closed + +jobs: + cleanup: + runs-on: ubuntu-latest + permissions: + # `actions:write` permission is required to delete caches + # See also: https://docs.github.com/en/rest/actions/cache?apiVersion=2022-11-28#delete-a-github-actions-cache-for-a-repository-using-a-cache-id + actions: write + contents: read + steps: + - name: Check out code + uses: actions/checkout@v4 + + - name: Cleanup + run: | + gh extension install actions/gh-actions-cache + + REPO=${{ github.repository }} + BRANCH=refs/pull/${{ github.event.pull_request.number }}/merge + + echo "Fetching list of cache key" + cacheKeysForPR=$(gh actions-cache list -R $REPO -B $BRANCH | cut -f 1 ) + + ## Setting this to not fail the workflow while deleting cache keys. + set +e + echo "Deleting caches..." + for cacheKey in $cacheKeysForPR + do + gh actions-cache delete $cacheKey -R $REPO -B $BRANCH --confirm + done + echo "Done" + env: + GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}