From c7008dab945b4bc8d49deb14fec794a803b38efb Mon Sep 17 00:00:00 2001 From: Luca Forstner Date: Wed, 4 Sep 2024 08:23:06 +0000 Subject: [PATCH] fix(node): Replace dashes in `generic-pool` span origins with underscores --- .../suites/tracing/genericPool/test.ts | 8 ++++---- packages/node/src/integrations/tracing/genericPool.ts | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/dev-packages/node-integration-tests/suites/tracing/genericPool/test.ts b/dev-packages/node-integration-tests/suites/tracing/genericPool/test.ts index a61782ae0fe5..114d3a909188 100644 --- a/dev-packages/node-integration-tests/suites/tracing/genericPool/test.ts +++ b/dev-packages/node-integration-tests/suites/tracing/genericPool/test.ts @@ -11,18 +11,18 @@ describe('genericPool auto instrumentation', () => { spans: expect.arrayContaining([ expect.objectContaining({ description: expect.stringMatching(/^generic-pool\.ac?quire/), - origin: 'auto.db.otel.generic-pool', + origin: 'auto.db.otel.generic_pool', data: { - 'sentry.origin': 'auto.db.otel.generic-pool', + 'sentry.origin': 'auto.db.otel.generic_pool', }, status: 'ok', }), expect.objectContaining({ description: expect.stringMatching(/^generic-pool\.ac?quire/), - origin: 'auto.db.otel.generic-pool', + origin: 'auto.db.otel.generic_pool', data: { - 'sentry.origin': 'auto.db.otel.generic-pool', + 'sentry.origin': 'auto.db.otel.generic_pool', }, status: 'ok', }), diff --git a/packages/node/src/integrations/tracing/genericPool.ts b/packages/node/src/integrations/tracing/genericPool.ts index 55b8b6095f64..8bc84554071c 100644 --- a/packages/node/src/integrations/tracing/genericPool.ts +++ b/packages/node/src/integrations/tracing/genericPool.ts @@ -25,7 +25,7 @@ const _genericPoolIntegration = (() => { spanDescription === 'generic-pool.aquire' || spanDescription === 'generic-pool.acquire'; if (isGenericPoolSpan) { - span.setAttribute(SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN, 'auto.db.otel.generic-pool'); + span.setAttribute(SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN, 'auto.db.otel.generic_pool'); } }); },