Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Give Fetch/XHR breadcrumbs a log level based on status code #13359

Closed
lforst opened this issue Aug 13, 2024 · 1 comment · Fixed by #13711
Closed

Give Fetch/XHR breadcrumbs a log level based on status code #13359

lforst opened this issue Aug 13, 2024 · 1 comment · Fixed by #13711
Labels
Meta: Good First Issue Meta: Help Wanted Package: core Issues related to the Sentry Core SDK

Comments

@lforst
Copy link
Member

lforst commented Aug 13, 2024 •
edited
Loading

Higher order tracking issue: getsentry/team-sdks#100

Description

It came up that the breadcrumbs we create for 4xx and 5xx fetch requests are pretty tame and don't stick out. We can sorta fix this by changing the log level of the breadcrumbs based on the response status code:

  • 5xx should probably be error
  • 4xx should probably be warning/error
@cleptric cleptric mentioned this issue Aug 14, 2024
Open
@lforst lforst self-assigned this Aug 14, 2024
@lforst lforst removed their assignment Aug 26, 2024
@mydea mydea added Meta: Help Wanted Package: core Issues related to the Sentry Core SDK Meta: Good First Issue labels Sep 13, 2024
@Zen-cronic Zen-cronic mentioned this issue Sep 18, 2024
Merged
2 tasks
@lforst lforst closed this as completed in 1f898b6 Sep 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

A PR closing this issue has just been released 🚀

This issue was closed by PR #13711, which was included in the 8.32.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Meta: Good First Issue Meta: Help Wanted Package: core Issues related to the Sentry Core SDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Set log level for Fetch/XHR breadcrumbs based on status code Zen-cronic/sentry-javascript
2 participants
@mydea @lforst