rymdport: Use %make command to build #4861
Labels
Packaging Problem
Building the package as-is fails ("FTBFS"), or other problem with the packaging of software
Priority: Normal
Normal priority
Please confirm there isn't an open report for this package
Name
Rymdport
Version
v3.7.0
Summary of the problem
I was looking through the Solus pkgspec for my application Rymdport (https://github.com/getsolus/packages/blob/main/packages/r/rymdport/package.yml) and noticed that the build step was hard-coded instead of using the
%make
command. To make sure that updates go smoothly in the future (or smoother), I would prefer if you ranmake
instead of hard-coding “go build” command and specific options passed to it as these might become wrong/outdated in the future. I’ll make sure that my makefile builds correctly, that is a promise :)More information
Some nerdy details as to why this came up:
I realised that I hadn’t added the tag
no_metadata
to the makefile to make sure that I turn off the feature in my toolkit that tries to load TOML metadata on startup (not turned off automatically due to how I build my app on Linux). It is not a big deal in any way but it makes startup ever so slightly faster and binaries a few kilobytes smaller.There is another migration tag that I will need for the next release to make sure that performance is as good as possible (I will want to opt in to the new threading model in the toolkit for better performance and no race conditions).
Doing this makes sure that the Solus package is as good as possible. As a former packager here, it sits close to my heart :)
The text was updated successfully, but these errors were encountered: