Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rymdport: Use %make command to build #4861

Closed
1 task done
Jacalz opened this issue Jan 18, 2025 · 3 comments
Closed
1 task done

rymdport: Use %make command to build #4861

Jacalz opened this issue Jan 18, 2025 · 3 comments
Labels
Packaging Problem Building the package as-is fails ("FTBFS"), or other problem with the packaging of software Priority: Normal Normal priority

Comments

@Jacalz
Copy link
Contributor

Jacalz commented Jan 18, 2025

Please confirm there isn't an open report for this package

  • I have searched through packaging problem reports

Name

Rymdport

Version

v3.7.0

Summary of the problem

I was looking through the Solus pkgspec for my application Rymdport (https://github.com/getsolus/packages/blob/main/packages/r/rymdport/package.yml) and noticed that the build step was hard-coded instead of using the %make command. To make sure that updates go smoothly in the future (or smoother), I would prefer if you ran make instead of hard-coding “go build” command and specific options passed to it as these might become wrong/outdated in the future. I’ll make sure that my makefile builds correctly, that is a promise :)

More information

Some nerdy details as to why this came up:

  • I realised that I hadn’t added the tag no_metadata to the makefile to make sure that I turn off the feature in my toolkit that tries to load TOML metadata on startup (not turned off automatically due to how I build my app on Linux). It is not a big deal in any way but it makes startup ever so slightly faster and binaries a few kilobytes smaller.

  • There is another migration tag that I will need for the next release to make sure that performance is as good as possible (I will want to opt in to the new threading model in the toolkit for better performance and no race conditions).

Doing this makes sure that the Solus package is as good as possible. As a former packager here, it sits close to my heart :)

@Jacalz Jacalz added Packaging Problem Building the package as-is fails ("FTBFS"), or other problem with the packaging of software Priority: Normal Normal priority labels Jan 18, 2025
@github-project-automation github-project-automation bot moved this to Triage in Solus Jan 18, 2025
@Jacalz
Copy link
Contributor Author

Jacalz commented Jan 18, 2025

FYI: If there is anything preventing you from using %make due to a broken Makefile on my part, I’ll happily fix that for you :)

@davidjharder
Copy link
Member

Hi Jacob 👋 didn't recognize the new avatar, lol. I'm happy to take a look at this

@github-project-automation github-project-automation bot moved this from Triage to Done in Solus Jan 21, 2025
@Jacalz
Copy link
Contributor Author

Jacalz commented Jan 22, 2025

Hi David. Hehe, thanks. Much appreciated :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Packaging Problem Building the package as-is fails ("FTBFS"), or other problem with the packaging of software Priority: Normal Normal priority
Projects
Status: Done
Development

No branches or pull requests

2 participants