Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better handle errors reported by reactive-grapqhl #3

Closed
alexstrat opened this issue Jan 23, 2019 · 1 comment
Closed

Better handle errors reported by reactive-grapqhl #3

alexstrat opened this issue Jan 23, 2019 · 1 comment

Comments

@alexstrat
Copy link
Contributor

alexstrat commented Jan 23, 2019 •
edited
Loading

In opposite to reference implementation, in reactive-grapqhl, when whatever errors happen (missing field), an error is thrown on subscription instead of adding it to errors array and continuing.

We need to catch those and add them to errors array to have better error reporting.
@alexstrat
Copy link
Contributor Author

Relates to d2iq-archive/reactive-graphql#13

@alexstrat alexstrat mentioned this issue Jan 23, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alexstrat