Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organize functions into fewer files #45

Open
howardbaik opened this issue Mar 1, 2024 · 2 comments
Open

Organize functions into fewer files #45

howardbaik opened this issue Mar 1, 2024 · 2 comments

Comments

@howardbaik
Copy link

Currently, this package's R/ directory contains one file for each function. So, the file demo-crowding.R contains demo_crowding(), the file demo-education.R contains demo_education(), and so on.

According to the "R code" chapter in R Packages, this extreme is bad. I suggest we have a single .R file contain a family of related functions. For ex, demo.R would contain all the demo_*() functions, handle.R would contain all the handle_*() functions, and so on.

@realbp
Copy link
Contributor

realbp commented Mar 1, 2024

Would love to talk more about this because I am all for organization! But for now, Sean has told me to keep the r files linear

@howardbaik
Copy link
Author

Sure, I'll talk to Sean tomorrow about this. Would love to learn about his reasoning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants