You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
For that to work easily, i'd like to make it so that tests could be run both:
with real http requests w/o manually doing so (right now it can take quite a while for a workflow to be available after submitting a job, so we have to sleep a while before running some other function to get some info about that job)
with vcr
Maybe it would work to somehow detect if we're inside a vcr::use_cassette block and vcr is turned off or on and behave accordingly, all in vcr::use_cassette block:
vcr is turned on & fixture IS NOT present: sleep/wait to make sure workflow/job info is available after cromwell_submit_batch calls
vcr is turned on & fixture IS present: no need to sleep/wait
vcr is turned off: sleep/wait after cromwell_submit_batch calls
The sleep/wait above could just be a Sys.sleep, or could be a retry situation with some backoff, or just same time gaps between each call until we get a 200 response
Once this is working, then idea is to have a matrix approach in the github actions yml file to test under different cromwell versions
The text was updated successfully, but these errors were encountered:
I feel very similarly to this issue as I do to #26 and #28, very important and could potentially be done now since rcromwell won't change much in v2.0 and the benefits would carry over, but it would require somewhat significant lift. Marking as v2.0 for now, but definitely could be convinced to put this in v1.X, especially if we can get all other high priority items done.
It'd be nice to test with the latest few versions of Cromwell, e.g., https://github.com/broadinstitute/cromwell/releases/tag/87 came out in May, and it'd be nice to test this pkg with 86 and 87 at least.
For that to work easily, i'd like to make it so that tests could be run both:
Maybe it would work to somehow detect if we're inside a
vcr::use_cassette
block and vcr is turned off or on and behave accordingly, all invcr::use_cassette
block:cromwell_submit_batch
callscromwell_submit_batch
callsThe sleep/wait above could just be a
Sys.sleep
, or could be a retry situation with some backoff, or just same time gaps between each call until we get a 200 responseOnce this is working, then idea is to have a matrix approach in the github actions yml file to test under different cromwell versions
The text was updated successfully, but these errors were encountered: