Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only map memory that is meant to be accessed by CPU #12

Open
kvark opened this issue May 4, 2020 · 0 comments
Open

Only map memory that is meant to be accessed by CPU #12

kvark opened this issue May 4, 2020 · 0 comments
Labels
aspect: API Issues with the API module: memory gfx-memory issues type: enhancement New feature or request

Comments

@kvark
Copy link
Member

kvark commented May 4, 2020

Currently, gfx-memory unconditionally maps everything that is CPU-visible. It assumes that 1) mapping is harmless if we don't actually do anything with it, and 2) that on most systems non-cpu-visible memory types will be preferred for private resources.

However, on Intel GPUs apparently all memory types are CPU-visible. We don't want to map everything and exhaust the resident memory space. We don't want to confuse RenderDoc - baldurk/renderdoc#1863 (comment)

I wish we could approach this without breaking the API though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aspect: API Issues with the API module: memory gfx-memory issues type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant