diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 5ebd16d7c2..5fd85de6b6 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -1,12 +1,25 @@ **Connections** _Link to the issues addressed by this PR, or dependent PRs in other repositories_ +When one pull request builds on another, please put "Depends on +#NNNN" towards the top of its description. This helps maintainers +notice that they shouldn't merge it until its ancestor has been +approved. Don't use draft PR status to indicate this. + **Description** _Describe what problem this is solving, and how it's solved._ **Testing** _Explain how this change is tested._ +**Squash or Rebase?** + +If your pull request contains multiple commits, please indicate whether +they need to be squashed into a single commit before they're merged, +or if they're ready to rebase onto `trunk` as they stand. In the +latter case, please ensure that each commit passes all CI tests, so +that we can continue to bisect along `trunk` to isolate bugs. +