slack-terminalize/util/_getCommand is too aggressive!

[alipourshahid]

@ggauravr this is a great library. I am using it for my team. I have come across and issue though.

_getCommand also recognizes the beginning of the commands as valid commands. For instant, if the command is "help", "h" is also recognized as valid and works.

Is this currently as-designed?

It'd be nice to be able to config this to work as either exact match or contains (the current behaviour).

[ggauravr]

@alipourshahid Glad to know it's useful for you! The only way it could work with h as a command is if you have actually defined it as a valid command or an alias to a valid command, like say as an alias for help.
Can you please paste a screenshot or something to help me understand the issue? Thanks again.

[alipourshahid]

@ggauravr the problem is actually the fact that it works when h is used. so the command is help but when users type h in slack, help is detected. I think the issue is the RegEx is detecting any character set that the command starts with e.g. if you type h, he, hel, and help. They are all detected as help.

[jamesallenuk]

Hopefully my PR sorts this out OK. I had to change the code after the regexp due to the difference in match results but think it simplifies the method without losing any logic.

[wjwolf79]

@jamesallenuk you're PR works perfectly. It really needs to get merged. I ended up moving the slack-terminalize to a local folder and making the changes there.

[ggauravr]

Sorry about that guys. Will merge by the end of the today. Thanks!

…

On Sun, Aug 20, 2017, 5:52 AM Wayne Wolf ***@***.***> wrote: @jamesallenuk <https://github.com/jamesallenuk> you're PR works perfectly. It really needs to get merged. I ended up moving the slack-terminalize to a local folder and making the changes there. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#12 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABMmb1kj-SaJKdhnUNT4A06Q7VqtifQYks5saCwdgaJpZM4J2O4o> .