Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification in media control carousel #79

Closed
silfversound opened this issue May 6, 2022 · 3 comments
Closed

Notification in media control carousel #79

silfversound opened this issue May 6, 2022 · 3 comments

Comments

@silfversound
Copy link

With Android 11 and 12 you are able to have the notification in a media control carousel like this:
https://android-developers.googleblog.com/2020/08/playing-nicely-with-media-controls.html

I'm getting my notification in the notifications list and not in the media control carousel. Have I missed anything or is it not implemented yet in this plugin?

@bikubi
Copy link

bikubi commented Sep 6, 2022

The article you mention says:

Now, the really good news. As long as you're using MediaStyle with a valid MediaSession token (both available since Lollipop API 21), media controls will be displayed for your app automatically - no extra work for you!

And I can find MediaStyle mentioned in the code, it goes back to #65, but it looks more like a shim and less like the "recap" in the article.

I suspect that the "shim" does not suffice (any more)?

EDIT: btw, I'm on Android 13 and also getting a "regular" notification and not the carousely one I know from Android 10.

@bikubi
Copy link

bikubi commented Sep 7, 2022

Looks like MediaStyle is missing the MediaSession token. I've fixed in my fork, seems to work; tested on Android 10 and 13 devices.
bikubi@47a87f3

@ghenry22
Copy link
Owner

This is fixed in v3.0.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants