Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Mergeable Library Support #127

Merged
merged 9 commits into from
Jun 4, 2024
Merged

Conversation

giginet
Copy link
Owner

@giginet giginet commented May 31, 2024

Introduce a new framework type, mergeable, to build a Mergeable Library.

--static flag is deprecated. Use --framework-type static instead.

@giginet giginet requested review from giuk-jung and freddi-kit May 31, 2024 11:57
Comment on lines +13 to +14
- [Configuring your project to use mergeable libraries | Apple Developer Documentation](https://developer.apple.com/documentation/xcode/configuring-your-project-to-use-mergeable-libraries)
- [Meet mergeable libraries - WWDC23 - Videos - Apple Developer](https://developer.apple.com/videos/play/wwdc2023/10268/)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thank you for the links

Mergeable frameworks have `LC_ATOM_INFO` load command in the binary. You can check it by `otool` command.

```shell
echo $(otool -l path/to/binary) | grep "LC_ATOM_INFO"
Copy link
Collaborator

@giuk-jung giuk-jung May 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q.path/to/binary means frameworkName.framework/frameworkName?

| -\-configuration, -c | Build configuration for generated frameworks (debug / release) | release |
| -\-output, -o | Path indicates a XCFrameworks output directory | $PACKAGE_ROOT/XCFrameworks |
| -\-embed-debug-symbols | Whether embed debug symbols to frameworks or not | - |
| -\-framework-type | Framework type to generate Available: dynamic, static or mergeable) | dynamic |
Copy link
Collaborator

@giuk-jung giuk-jung May 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q. Default is dynamic, correct?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, third column is the default value

@giginet
Copy link
Owner Author

giginet commented May 31, 2024

I added the test case

@giginet giginet merged commit 2d76897 into main Jun 4, 2024
3 checks passed
@giginet giginet deleted the mergeable-library-support branch June 4, 2024 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants