Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make release workflow enable to trigger manually #173

Merged
merged 3 commits into from
Jan 20, 2025
Merged

Make release workflow enable to trigger manually #173

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5113c05
Make release workflow enable to trigger manually
ikesyo Jan 16, 2025
f30e893
Use `published` type over `created` type for `release` trigger
ikesyo Jan 16, 2025
fa9a0cf
Use `github.event.release.tag_name`
ikesyo Jan 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,12 @@
on:
release:
types: [created]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about adding updated?

Copy link
Collaborator Author

@ikesyo ikesyo Jan 16, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

release trigger: https://docs.github.com/en/actions/writing-workflows/choosing-when-your-workflow-runs/events-that-trigger-workflows#release

  • published
  • unpublished
  • created
  • edited
  • deleted
  • prereleased
  • released

edited is triggered only when the description is updated so that's not appropriate I think.

Looks like published is better than created.

A release, pre-release, or draft of a release was published.

Copy link
Collaborator Author

@ikesyo ikesyo Jan 16, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why but the release workflow for 0.27.0 didn't ran

That was because I created the release as a draft initially.

https://docs.github.com/en/webhooks/webhook-events-and-payloads?actionType=created#release

A draft was saved, or a release or pre-release was published without previously being saved as a draft.

workflow_dispatch:
inputs:
tag:
description: 'Tag to build and upload artifact bundle for'
required: true
default: ${{ github.ref_name }}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this value is revision, can we update Zip files to the actual release?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can't upload in that case (for commit hashes).


name: Upload Artifact Bundle to Release
env:
Expand All @@ -21,7 +27,7 @@ jobs:
swift build --disable-sandbox -c release --arch arm64
swift build --disable-sandbox -c release --arch x86_64
- name: Get Current Tag
run: echo "TAG_NAME=${GITHUB_REF#refs/*/}" >> $GITHUB_ENV
run: echo "TAG_NAME=${{ inputs.tag || github.ref_name }}" >> $GITHUB_ENV
- name: Make Artifact Bundle
run: |
swift package --allow-writing-to-package-directory generate-artifact-bundle \
Expand Down