Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Providing a helm chart #84

Open
tropnikovvl opened this issue Apr 5, 2024 · 4 comments
Open

Providing a helm chart #84

tropnikovvl opened this issue Apr 5, 2024 · 4 comments

Comments

@tropnikovvl
Copy link

Hello!
Thanks for a great product!

It would be great to add a helm chart with versioning for its deployment.
For example, I now want to add my own labels, annotations, ingress or security policies and it’s not entirely clear how to do this.

Also, versioning would help me create automatic testing pipelines in different environments when releasing a new version.

Thank you!

@laszlocph
Copy link
Contributor

laszlocph commented Apr 8, 2024

Hello @tropnikovvl

Capacitor does not need elaborate manifests to be deployed. The only requirement, is the proper RBAC so it can gather the data.

own labels, annotations, ingress or security policies

My take on providing a Helm chart is a bit controversial perhaps, but I believe maintaining a Helm chart to be able to configure every possible knob of Kubernetes is not the best way to spend time. Of course I can be convinced otherwise, or if someone made a Helm chart already i can link to it, but I don't want to maintain that as of now.

Maybe using https://fluxcd.io/flux/components/kustomize/kustomizations/#patches on https://github.com/gimlet-io/capacitor?tab=readme-ov-file#flux would be a way to provide labels/annotations? Ingress and policies can be stored as standalone files.

@dshershov
Copy link

hi, @laszlocph
Helm is a widely used tool that people are used to working with.
I really don't know how I can modify this service with some modifies and helm templates can help me with that
Of course, you are not obliged to follow "the usual methods" or something like that, but I think that this request about providing a helm chart will come not only from the two of us
Thanks!

@sebastiangaiser
Copy link
Contributor

@laszlocph I started writing a Helm chart. For me question is now, do you want to have it as PR or should I publish it under my name?

@sebastiangaiser
Copy link
Contributor

I published my Helm chart now: https://github.com/sebastiangaiser/helm-charts/releases/tag/capacitor-0.1.0
Feel free to give me feedback/PRs on it.

@laszlocph in case you're interested in merging it "upstream" or adding a link, please let me know

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants