Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login field should not be case sensitive #436

Open
baseliners opened this issue Jun 21, 2013 · 4 comments
Open

Login field should not be case sensitive #436

baseliners opened this issue Jun 21, 2013 · 4 comments
Labels

Comments

@baseliners
Copy link

It appears that the login field (email address) is case sensitive. This should really be case insensitive. Thanks!

@atd
Copy link
Contributor

atd commented Jun 21, 2013

Hi @baseliners this is a Devise issue. Please take a look to https://github.com/plataformatec/devise/wiki/How-To:-Use-case-insensitive-emails on how to configure this in your application

@atd atd closed this as completed Jun 21, 2013
@baseliners
Copy link
Author

It appears that Devise does have the correct behavior but SocialStream is overriding it - user.rb has some functions which seem to imply this. Also, the email address is downcased in the DB, just that SS's changes result in the user-entered email not being downcased before comparison with what's in the DB. So, in summary, this issue still appears to be within SS code. Think we have a fix for it, will post later tonight.

@baseliners
Copy link
Author

To close the loop on this, we ended up extending the authentication controller and downcasing the login before doing the comparison. But this should be fixed in SS, IMHO.

@atd
Copy link
Contributor

atd commented Jul 1, 2013

Please, send us a pull request. We will be happy to merge it. Thank you!

@atd atd reopened this Jul 1, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants