Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[object Object] instead of data #3

Open
Neurodriver opened this issue Jun 14, 2015 · 8 comments
Open

[object Object] instead of data #3

Neurodriver opened this issue Jun 14, 2015 · 8 comments

Comments

@Neurodriver
Copy link

Plugin is showing just [object Object] instead of data from series. Problem is visible on demo page as well:
https://gionkunz.github.io/chartist-js/plugins.html

@alexstanbury
Copy link
Contributor

I'm seeing this too, I'll try and see what is wrong and submit a PR if I can work it out...

@kaspar-allenbach
Copy link

+1

@gionkunz
Copy link
Owner

Hi there. Unfortunately I can't look into this right now. The issue is that value objects are now two dimensional and the plugin needs to be updated. Instead of using value to create the label, this expression should be used instead: value.x === undefined ? value.y : value.x + ', ' + value.y. A PR would be much appreciated.

@alexstanbury
Copy link
Contributor

Hi, I worked it out and have a PR ready to submit, I will send it over tomorrow morning with the fix.

@gionkunz
Copy link
Owner

👍

@alexstanbury
Copy link
Contributor

PR #4 submitted, hope I've done it properly - It's my first one ;)

@gionkunz
Copy link
Owner

I've published 0.0.4 with your changes @alexstanbury

@gionkunz
Copy link
Owner

@Neurodriver can you also verify if the issue is resolved on your side?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants