Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] scikit-learn dependency should be range #706

Open
abhinavnatarajan opened this issue Nov 6, 2024 · 0 comments · May be fixed by #709
Open

[BUG] scikit-learn dependency should be range #706

abhinavnatarajan opened this issue Nov 6, 2024 · 0 comments · May be fixed by #709
Labels
bug Something isn't working

Comments

@abhinavnatarajan
Copy link

abhinavnatarajan commented Nov 6, 2024

Describe the bug
v0.6.2 of giotto-tda has a strict requirement on scikit-learn==1.3.2, which is around 6 months old as of today. This means that if a user has any newer version of scikit-learn, 'pip install giotto-tda' will try to build giotto-tda from source instead of installing the PyPI wheels. This leads to several problems while installing the package due to the build process being non-trivial.

The version specifier should be changed to 'scikit-learn>=1.3.2' or 'scikit-learn~=1.3' (the latter is roughly equivalent to 'scikit-learn>=1.3, scikit-learn==1.*' which would nominally ensure no breakage assuming that scikit-learn follows semver).

EDIT: This bug only affects Python>=3.12, since this bug is a regression from giotto-tda 0.6.1 which is compatible with Python<3.12 and has a more permissive dependency specifier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
1 participant