Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minimal-sdk: support compiling clar.c #86

Closed

Conversation

dscho
Copy link
Member

@dscho dscho commented Aug 17, 2024

In an upcoming contribution, the upstream Git project will want to use https://github.com/clar-test/clar, a powerful C-based test framework. This framework requires the shellapi.h header, which we hereby support in the minimal Git for Windows SDK used in CI builds.

In an upcoming contribution, the upstream Git project will want to use
https://github.com/clar-test/clar, a powerful C-based test framework.
This framework requires the `shellapi.h` header, which we hereby support
in the minimal Git for Windows SDK used in CI builds.

Signed-off-by: Johannes Schindelin <[email protected]>
@dscho dscho self-assigned this Aug 17, 2024
@dscho dscho mentioned this pull request Aug 20, 2024
@dscho
Copy link
Member Author

dscho commented Aug 20, 2024

A better alternative has been found: drop #include <shellapi.h>, as it is not needed for clar.c but is rather just a forgotten remainder of a long-superseded patch.

Therefore this here PR is not needed.

@dscho dscho closed this Aug 20, 2024
@dscho dscho deleted the support-clar-test-in-minimal-sdk branch August 20, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant