Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Config value 'user.name' was not found" with custom .gitconfig. #875

Closed
andreinagy opened this issue Nov 22, 2022 · 3 comments
Closed

"Config value 'user.name' was not found" with custom .gitconfig. #875

andreinagy opened this issue Nov 22, 2022 · 3 comments

Comments

@andreinagy
Copy link

Hi, first of all I want to thank you for making gitup, it's awesome!

Preconditions

I recently started using a more complex setup, with different git identities per directory.
example ~/.gitconfig

[includeIf "gitdir:~/ABC/"]
	path = .gitconfig-ABC
[includeIf "gitdir:~/DEF/"]
	path = .gitconfig-DEF

example ~/.gitconfig-ABC:

[user]
	name = My Name
	email = [email protected]

Steps to reproduce:

  1. open a directory with changes in a terminal.
  2. run git config user.name (the command correctly outputs a username)
  3. open the directory in gitup and try to comit.

Expected result:

The commit is successful. With my setup it's possible to commit using the command line or another git GUI.

Actual result:

The bottom of the gitup window there is a message "Committing as NA".
bottom identity N/A
The commit fails with "Config value 'user.name' was not found".
error message

Other notes:

  • I found an older issue, but I have git properly set up link
  • GitUp version 1.3.2 (1045)
@lucasderraugh
Copy link
Collaborator

lucasderraugh commented Nov 22, 2022

Thanks, @andreinagy! I believe this isn't supported at the moment because of #315. Though in the master branch we have picked up a recent version of libgit2, so perhaps this works automatically now. I haven't tested.

Looking to push a build out to the continuous channel this week. You can either try building master to see if it fixes it or wait until the continuous release and let me know if it resolves anything.

@andreinagy
Copy link
Author

Hi @lucasderraugh, sorry for the late reply,

It works by building on the latest main, in the app I didn't get an update yet.
Screenshot 2022-11-30 at 11 10 58

Thanks for the help!

@lucasderraugh
Copy link
Collaborator

@andreinagy Just pushed 1.3.3 to continuous. I'm going to close this ticket out as hopefully being resolved. If it's not the case in 1.3.3, please let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants