Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove DataProvider and use the Database class directly #441

Open
boudra opened this issue Feb 15, 2024 · 0 comments
Open

remove DataProvider and use the Database class directly #441

boudra opened this issue Feb 15, 2024 · 0 comments

Comments

@boudra
Copy link
Contributor

boudra commented Feb 15, 2024 •
edited
Loading

we have an interface called DataProvider, this was used in the old version where data was stored in JSON files, but its stil used in the calculator, via the DatabaseProvider, this will be a source of slow queries as we query all data.

we now have a Database class with granular queries that should be performant, we should delete the DataProvider and use the Database directly.
@boudra boudra added this to the GG20 Readiness milestone Feb 15, 2024
@boudra boudra removed this from the GG20 Readiness milestone May 15, 2024
@boudra boudra changed the title optimize matching estimate queries migrate DataProvider to use the Database class directly May 15, 2024
@boudra boudra changed the title migrate DataProvider to use the Database class directly remove DataProvider and use the Database class directly May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@boudra