Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Including Example Images in Gradio Demo #2

Open
gitgoap opened this issue Dec 28, 2024 · 16 comments
Open

[Enhancement]: Including Example Images in Gradio Demo #2

gitgoap opened this issue Dec 28, 2024 · 16 comments
Assignees

Comments

@gitgoap
Copy link
Owner

gitgoap commented Dec 28, 2024

Description

Add 2-3 fog images from this repo readme as an example in the Gradio interface for Defogify, similar to the below image

Similar implementatation

Visit this page to checkout below example
Screenshot 2024-12-28 223246

@gitgoap
Copy link
Owner Author

gitgoap commented Dec 30, 2024

Get the issue assigned before working by commenting on the issue.

@GhostisLive
Copy link
Contributor

Assign me with this work

@gitgoap
Copy link
Owner Author

gitgoap commented Jan 2, 2025

Hey, @GhostisLive
Thanks for showing interest.
Go for this issue, you are assigned!

@GhostisLive
Copy link
Contributor

@gitgoap thank you for assigning me!!

@GhostisLive
Copy link
Contributor

@gitgoap I have already completed the task, and it is working fine. I am sharing a screenshot before creating a pull request. Please let me know if any changes are required.
image_2025-01-02_224830391

@gitgoap
Copy link
Owner Author

gitgoap commented Jan 2, 2025

Good Work.
Just remove the heading and it's description.

@GhostisLive
Copy link
Contributor

@gitgoap ok

@GhostisLive
Copy link
Contributor

image
Do you need any more changes? @gitgoap

@gitgoap
Copy link
Owner Author

gitgoap commented Jan 3, 2025

@GhostisLive Suggestion: Put all your changes related to this issue on the Pull Request page. For example, these screenshots should ideally be on the PR page, not the issue page.
If this is done then it's easier for a maintainer to review the changes.

@GhostisLive
Copy link
Contributor

GhostisLive commented Jan 3, 2025

@gitgoap Ok, I will update the PR. This is my first time contributing, so I am still figuring things out. Thanks for the suggestion.

@GhostisLive
Copy link
Contributor

@gitgoap Can u assign the points for SWOC 2025?

@gitgoap
Copy link
Owner Author

gitgoap commented Jan 8, 2025

@GhostisLive You were assigned points yesterday itself. Please check carefully.

@GhostisLive
Copy link
Contributor

Thanks I have already checked this evening

@GauravKarakoti
Copy link

Is this issue still open or done?

@GhostisLive
Copy link
Contributor

Issue is already closed

@gitgoap
Copy link
Owner Author

gitgoap commented Jan 9, 2025

I have still kept this issue, just to show that I want this kind of contribution from others.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants