Skip to content

Commit

Permalink
Go: Update unit tests for hasInvalidToolchainVersion to assume inst…
Browse files Browse the repository at this point in the history
…alled version is `1.21`
  • Loading branch information
mbg committed Feb 19, 2025
1 parent 9a89426 commit d26f49f
Showing 1 changed file with 6 additions and 4 deletions.
10 changes: 6 additions & 4 deletions go/extractor/project/project_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -39,18 +39,20 @@ func parseModFile(t *testing.T, contents string) *modfile.File {
return modFile
}

func testHasInvalidToolchainVersion(t *testing.T, contents string) bool {
return hasInvalidToolchainVersion(parseModFile(t, contents))
func testHasInvalidToolchainVersion(t *testing.T, installedToolchainVersion util.SemVer, contents string) bool {
return hasInvalidToolchainVersion(installedToolchainVersion, parseModFile(t, contents))
}

func TestHasInvalidToolchainVersion(t *testing.T) {
installedToolchainVersion := util.NewSemVer("1.21")

invalid := []string{
"go 1.21\n",
"go 1.22\n",
}

for _, v := range invalid {
if !testHasInvalidToolchainVersion(t, v) {
if !testHasInvalidToolchainVersion(t, installedToolchainVersion, v) {
t.Errorf("Expected testHasInvalidToolchainVersion(\"%s\") to be true, but got false", v)
}
}
Expand All @@ -62,7 +64,7 @@ func TestHasInvalidToolchainVersion(t *testing.T) {
}

for _, v := range valid {
if testHasInvalidToolchainVersion(t, v) {
if testHasInvalidToolchainVersion(t, installedToolchainVersion, v) {
t.Errorf("Expected testHasInvalidToolchainVersion(\"%s\") to be false, but got true", v)
}
}
Expand Down

0 comments on commit d26f49f

Please sign in to comment.